Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails on Go 1.11 #4873

Closed
bep opened this issue Jun 23, 2018 · 3 comments
Closed

Test fails on Go 1.11 #4873

bep opened this issue Jun 23, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@bep
Copy link
Member

bep commented Jun 23, 2018

See https://travis-ci.org/gohugoio/hugo/jobs/395910881

@bep bep added this to the v0.43 milestone Jun 23, 2018
@anthonyfok
Copy link
Member

Thank you so much for bringing this issue to my attention!
No more API breaking change in go1.11 according to golang/go#25968! I will revert my previous "fix" right away.

@anthonyfok
Copy link
Member

Full commit log:

Revert "tpl: Support text/template/parse API change in go1.11"

Go developers have undone the breaking API changes in the following commit:

commit bedfa4e1c37bd08063865da628f242d27ca06ec4
Author: Daniel Theophanes kardianos@gmail.com
Date: Thu Jun 21 10:41:26 2018 -0700

text/template/parse: undo breaking API changes

golang.org/cl/84480 altered the API for the parse package for
clarity and consistency. However, the changes also broke the
API for consumers of the package. This CL reverts the API
to the previous spelling, adding only a single new exported
symbol.

Fixes #25968

Change-Id: Ieb81054b61eeac7df3bc3864ef446df43c26b80f
Reviewed-on: https://go-review.googlesource.com/120355
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Rob Pike <r@golang.org>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>

See golang/go#25968

This reverts commit 9f27091.

Closes #4784
Fixes #4873

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants