Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially garbled content when borrow from another language/site #4986

Closed
bep opened this issue Jul 23, 2018 · 1 comment · Fixed by #4987
Closed

Potentially garbled content when borrow from another language/site #4986

bep opened this issue Jul 23, 2018 · 1 comment · Fixed by #4987

Comments

@bep
Copy link
Member

bep commented Jul 23, 2018

Not a particularly new issue, and I suspect not very common, as it happens only when:

  • You borrow .Content from another language.
  • I think that .Content also needs a shortcode for this to happen.

I will put this on the 0.45.1 milestone, as I need a fix for this. There will probably be some regressions to put there as well.

@bep bep added the Bug label Jul 23, 2018
@bep bep added this to the v0.45.1 milestone Jul 23, 2018
bep added a commit to bep/hugo that referenced this issue Jul 23, 2018
If a content file contains shortcode(s), we have logic in place to re-render it per output format.

We also have logic in place that avoids making a copy of the content used for this process if we don't need it.

This was before this commit limited to server mode and if the page should be output to multiple formats.

But there is a third case: If a site (language) borrows and renders `.Content` from another language. This would, before this commit, behave oddly for content with shortcodes.

Fixes gohugoio#4986
@bep bep closed this as completed in #4987 Jul 23, 2018
bep added a commit that referenced this issue Jul 23, 2018
If a content file contains shortcode(s), we have logic in place to re-render it per output format.

We also have logic in place that avoids making a copy of the content used for this process if we don't need it.

This was before this commit limited to server mode and if the page should be output to multiple formats.

But there is a third case: If a site (language) borrows and renders `.Content` from another language. This would, before this commit, behave oddly for content with shortcodes.

Fixes #4986
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant