Regression in 0.60.0 for $headless ?

[jensamunch]

What version of Hugo are you using (hugo version)?

Moving from 0.59.1 to 0.60.1 quietely (no warnings) stopped showing our headless content.

Here's an example of the code that outputs nothing with 0.60.0

<section class="customer-logos section">
	<div class="container">
		<div class="customer-logos-inner section-inner has-top-divider">
			<h2 class="section-title text-center mt-0">{{ .Site.Params.logos }}</h2>
			<div class="customer-logos-wrap is-revealing">
				{{ $headless := .Site.GetPage "page" "headless/customer-logos" }}
				{{ $reusablePages := $headless.Resources.Match "*" }}
				{{ range $reusablePages }}
				<div class="customer-logo">
					<a href="{{ .Params.link }}" target="_blank">
						{{ with .Params.image }}
						{{ $original := resources.Get .  }}
						{{ $coverScaled2x := $original.Resize "x160 center" }}
						{{ $coverScaled1x := ($coverScaled2x.Resize "x80") }}
						<img srcset="{{ $coverScaled1x.RelPermalink }} 1x, {{ $coverScaled2x.RelPermalink }} 2x" src="{{ $coverScaled1x.RelPermalink }}" width="{{ $coverScaled1x.Width }}" height="{{ $coverScaled1x.Height }}">
						{{ end }}
					</a>
				</div>
				{{ end }}
			</div>
		</div>
	</div>
</section>

[jensamunch]

[jensamunch]

[jensamunch]

[onedrawingperday]

This seems related to what has already been reported in the forum about HTML with indentation contained in shortcodes and partials being wrapped in pre and code elements.

https://discourse.gohugo.io/t/0-60-0-goldmark-html-indentation-in-partial-shortcode-wrapped-in-pre-code/22019/

I have already advised @divinerites to report this bug in the Hugo issue tracker.

@jensamunch as a workaround please remove the indentation from the HTML and let us know..

[jensamunch]

Ok will try. Super confusing to me since this is a partial template. I wouldn’t expect Hugo to be opinionated about my formatting there. Only in markup.

Isn’t it normal to beautify HTML code for readability?

[divinerites]

Yep @jensamunch it is exactly my thought (written in the #6553).

A Workaround is flatting all HTML in partials called by shortcode.

[jensamunch]

Does atom have a plugin that allows me to flatten all files? Seems like a lot of manual work. Hmm I think I’ll Stay on Black Friday

[jensamunch]

Hmmm. This doesn't seem to be the same issue. Now back at laptop and there is still no HTML output from flat partial:

<section class="customer-logos section">
<div class="container">
<div class="customer-logos-inner section-inner has-top-divider">
<h2 class="section-title text-center mt-0">{{ .Site.Params.logos }}</h2>
<div class="customer-logos-wrap">
{{ $headless := .Site.GetPage "page" "headless/customer-logos" }}
{{ $reusablePages := $headless.Resources.Match "*" }}
{{ range $reusablePages }}
<div class="customer-logo">
<a href="{{ .Params.link }}" target="_blank">
{{ with .Params.image }}
{{ $original := resources.Get .  }}
{{ $coverScaled2x := $original.Resize "x160 center" }}
{{ $coverScaled1x := ($coverScaled2x.Resize "x80") }}
<img srcset="{{ $coverScaled1x.RelPermalink }} 1x, {{ $coverScaled2x.RelPermalink }} 2x" src="{{ $coverScaled1x.RelPermalink }}" width="{{ $coverScaled1x.Width }}" height="{{ $coverScaled1x.Height }}">
{{ end }}
</a>
</div>
{{ end }}
</div>
</div>
</div>
</section>

[bep]

Stay on Black Friday

That's tomorrow :-)

This seems to be a bug in Goldmark -- I will take that with him. He is very quick in fixing stuff...

I'm closing this in favour of #6553 .

A general tip about shortcodes and HTML is that in some cases it can make sense to use the {{< separator, which makes sure that the Markdown engine does not mess with it.

[jensamunch]

Actually wait @bep - this is not the same issue.

My headless folder was called "customer-logos". When I changed it to "customerlogos" everything worked again.

No need to flatten the HTML. So unrelated.

[jensamunch]

I'm super confused. It's randomly working and not working...I'm just changing file names and formatting..I can't make any sense of a pattern.

[bep]

I'm super confused. It's randomly working and not working...

It's called parallelism ... I found the bug and will fix it soon.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.