Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Mmark to version 2 instead of dropping it entirely #7023

Closed
oblitum opened this issue Mar 5, 2020 · 12 comments
Closed

Upgrade Mmark to version 2 instead of dropping it entirely #7023

oblitum opened this issue Mar 5, 2020 · 12 comments

Comments

@oblitum
Copy link

oblitum commented Mar 5, 2020

As suggested at #7022 (comment), this issue has been raised for the consideration of upgrading support for the Mmark dialect to version 2 onwards, instead of dropping support for .mmark files entirely.

@oblitum oblitum changed the title Upgrade Mmark to version 2 instead of dropping it enterely Upgrade Mmark to version 2 instead of dropping it entirely Mar 5, 2020
@stale
Copy link

stale bot commented Jul 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Stale label Jul 3, 2020
@oblitum
Copy link
Author

oblitum commented Jul 3, 2020

If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

Still pretty important and relevant given there's no seamless option as Mmark for math rendering according to reports (1, 2), it's still best one can get. Also nice and important to not break compatibility leaving many user's files broken or stuck in an old hugo version.

@stale stale bot removed the Stale label Jul 3, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Stale label Dec 25, 2020
@oblitum
Copy link
Author

oblitum commented Dec 26, 2020

No further info besides #7023 (comment) and that people seem to support this request.

@stale stale bot removed the Stale label Dec 26, 2020
@mohkale
Copy link

mohkale commented Jul 24, 2021

Did this change go through? I've just noticed all the block-level attributes I had for lists or other elements seem to have stopped working after a recent hugo upgrade. So now I see literal {.some-class} in the output. I believe goldmark supported these but only for headings and blackfriday doesn't seem to support them at all. The docs still mention block-level attributes, but they no-longer seem to be working 😢.

@oblitum
Copy link
Author

oblitum commented Jul 24, 2021

@mohkale sources still point to mmark v1.

@mohkale
Copy link

mohkale commented Jul 24, 2021

@oblitum

That's strange. Must be a configuration update or something to that affect. I've downgraded to v0.85.0 and everything seems to be working again.

bep added a commit to bep/hugo that referenced this issue Jul 25, 2021
@oblitum
Copy link
Author

oblitum commented Aug 31, 2021

Oh no. Mmark is set to be removed on 0.88!

As most upvoted currently we're at position 29 out of 605 open issues. Upvote count is roughly 1/10 of the most upvoted issue.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions github-actions bot added the Stale label Sep 1, 2022
@oblitum
Copy link
Author

oblitum commented Sep 1, 2022

This is still just as relevant today as it was before. Anyway, I personally don't care anymore, I've pinned the last version of hugo that supported Mmark (which has been dropped already in the latest versions) on all installations I have because I'm not willing to convert all my Mmark content to another thing just to miss features. Feel free to close.

@jmooring jmooring closed this as completed Sep 1, 2022
@oblitum
Copy link
Author

oblitum commented Sep 1, 2022

Closed as not completed.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants