Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hugo to use WithAllClasses from Chroma #7167

Closed
acahir opened this issue Apr 13, 2020 · 3 comments · Fixed by #7168
Closed

Update hugo to use WithAllClasses from Chroma #7167

acahir opened this issue Apr 13, 2020 · 3 comments · Fixed by #7168
Labels
Enhancement Outdated

Comments

@acahir
Copy link
Contributor

acahir commented Apr 13, 2020

Modify hugo to use WithAllClasses() when running hugo gen chromastyles --style=monokai > syntax.css to create CSS stylesheet.

Small change in chroma to output all css class definitions, even if they have redundant coloring with current style. Prevents any modifications to the style from missing elements.

I believe it's only a matter of changing WithClasses to WithAllClasses here.

I will try to see if I can submit a PR, but haven't actually tried compiling hugo yet (still unfamiliar with Go) so noting this here.
@bep
Copy link
Member

bep commented Apr 13, 2020

I believe it's only a matter of changing WithClasses to WithAllClasses here.

Yes, but we also need to update the Chroma version (could ask him to tag a release version?)

@bep bep added Enhancement and removed Proposal labels Apr 13, 2020
@acahir
Copy link
Contributor Author

acahir commented Apr 13, 2020

Good point. I'll add it to the chroma issue.

acahir added a commit to acahir/hugo that referenced this issue Apr 13, 2020
@acahir
Modify gen chromastyles to output all CSS classes
205574d 
Chroma was updated to include a new function to output all CSS
classes without skipping any considered redundant with the current
style.

This will modify the `hugo gen chromastyles` command to use this new
function by default, which avoids potential problems if the style is
later modified.

Also includes requires the updated Chroma (v0.7.2).

Resolves gohugoio#7167
@acahir acahir mentioned this issue Apr 13, 2020
Merged
@bep bep closed this as completed in #7168 Apr 13, 2020
bep pushed a commit that referenced this issue Apr 13, 2020
@acahir
commands: Modify gen chromastyles to output all CSS classes
102ec2d 
Chroma was updated to include a new function to output all CSS
classes without skipping any considered redundant with the current
style.

This will modify the `hugo gen chromastyles` command to use this new
function by default, which avoids potential problems if the style is
later modified.

Also includes requires the updated Chroma (v0.7.2).

Resolves #7167
@fmotrifork fmotrifork mentioned this issue May 7, 2020
Merged
@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement Outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify gen chromastyles to output all CSS classes acahir/hugo
2 participants
@bep @acahir