Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojify break link #7913

Closed
tonka3000 opened this issue Nov 1, 2020 · 7 comments
Closed

Emojify break link #7913

tonka3000 opened this issue Nov 1, 2020 · 7 comments
Labels
Milestone

Comments

@tonka3000
Copy link

tonka3000 commented Nov 1, 2020

Hey,

I've activated emojify (via enableEmoji = true in my config.toml) today on my site. It works great, but it breaks some of my links when there is an emoji like part in it.

In my case this is a sharepoint link created from office 365, so I can not change the link.

So the link look like https://my.sharepoint.com/:x:/g/personal/namehere/KKFASDAskjlsaASDlkj. The problem is the :x:. Hugo make a ❌ out of it and so the link breaks. I have a normal markdown link like [test link](https://my.sharepoint.com/:x:/g/personal/namehere/KKfRIQdgXJJPrFFUwAAsPMcBpGYDTO)

The only workaround would be a shortlink service, but the site should also work without internet access, so it is not an option for me.

Expected behavior

Hugo should preserve emoji like syntax in markdown links or links in general.

What version of Hugo are you using (hugo version)?

$ hugo version
Hugo Static Site Generator v0.77.0-EF290125 windows/amd64 BuildDate: 2020-10-30T10:13:29Z

Does this issue reproduce with the latest release?

Yes

@tylerchambers
Copy link

tylerchambers commented Nov 9, 2020

Because RFC 3492 says URLs with emoji are valid, there are probably two ways we could handle this:

  1. Allow the specification of a custom emoji deliminator character(s) in config.toml
  2. A flag to prevent the emojification of URLs

1 sounds better to me, because it would be easier.

I'm going to start working on 1, but if any contributors have other ideas let me know.

EDIT: never mind. I'm unsure how config loading works in this project, and I'm not sure where to ask. But either of those options would work.

@bep bep modified the milestones: v0.79, v0.80 Nov 27, 2020
@bep bep modified the milestones: v0.80, v0.81 Jan 2, 2021
@bep bep modified the milestones: v0.81, v0.82 Feb 19, 2021
@bep bep modified the milestones: v0.82, v0.83 Mar 21, 2021
@bep bep modified the milestones: v0.83, v0.84 May 1, 2021
@bep bep modified the milestones: v0.84, v0.85 Jun 18, 2021
@bep bep modified the milestones: v0.85, v0.86 Jul 5, 2021
@bep bep modified the milestones: v0.86, v0.87, v0.88 Jul 26, 2021
@bep bep modified the milestones: v0.88, v0.89 Sep 2, 2021
@bep bep modified the milestones: v0.89, v0.90 Nov 2, 2021
@bep bep modified the milestones: v0.90, v0.91.0 Dec 13, 2021
@bep bep modified the milestones: v0.91.0, v0.92.0 Dec 22, 2021
@bep bep removed this from the v0.92.0 milestone Jan 12, 2022
@bep bep modified the milestones: v0.109.0, v0.111.0, v0.110.0 Jan 26, 2023
@bep bep modified the milestones: v0.111.0, v0.112.0 Feb 15, 2023
@bep bep modified the milestones: v0.112.0, v0.113.0 Apr 15, 2023
@bep bep modified the milestones: v0.113.0, v0.115.0 Jun 13, 2023
@bep bep modified the milestones: v0.115.0, v0.116.0 Jun 30, 2023
@bep bep modified the milestones: v0.116.0, v0.117.0 Aug 1, 2023
@bep bep modified the milestones: v0.117.0, v0.118.0 Aug 30, 2023
@bep bep modified the milestones: v0.118.0, v0.119.0 Sep 15, 2023
@bep bep modified the milestones: v0.119.0, v0.120.0 Oct 4, 2023
@bep bep modified the milestones: v0.120.0, v0.121.0 Oct 31, 2023
@jmooring
Copy link
Member

This was resolved in v0.120.0 with #11593

Copy link

github-actions bot commented Dec 7, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants