Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make enableEmoji into a Markdown/Goldmark only feature #11598

Closed
bep opened this issue Oct 24, 2023 · 1 comment
Closed

Make enableEmoji into a Markdown/Goldmark only feature #11598

bep opened this issue Oct 24, 2023 · 1 comment

Comments

@bep
Copy link
Member

bep commented Oct 24, 2023

This is a breaking change for some, but I suspect few. The current implementation have a few issues, mostly due to the current implementation doing very simple search and replace, which does not detect code blocks etc. where it does not make sense to emojify the content.

Instead of spending lots of time fixing this, we will add the Goldmark extension which handles this for us. But that will not work with Asciidoc, plain HTML etc.

See #7332
See #7913
See #11587

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant