Pagination: consider dropping href="#" for disabled buttons since it is an invalid fragment id

[chalin]

Great update in #8602 @jmooring!

Could we drop the invalid anchors (href="#") for disabled buttons?

<a href="#" aria-disabled="true" ...>

It's tripping link checking. For example, see

hugo/tpl/tplimpl/embedded/templates/pagination.html

Line 43 in 805c24c

<a href="#" aria-disabled="true" aria-label="First" class="page-link" role="button" tabindex="-1"><span aria-hidden="true">&laquo;&laquo;</span></a>

Prior to #8602, the previous button omitted the href attribute when there was no previous page.

/cc @austinlparker @nate-double-u

[jmooring]

@chalin Yes, I will look at this. Link checking is one problem, but the primary driver is that the fragment resolves to the server root when serving from a subdirectory with a <base href="{{ site.BaseURL }}"> element.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.