-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-language support for Goldmark Typographer #9727
Comments
I would love this feature in hugo. I spend a lot of time in fine-tweaking the language settings but this little piece is still missing. Since the underlying lib already supports this, it should only be a matter of adding a config flag, as suggested in yuin/goldmark#59 (comment) . |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Goldmark Typographer extension used by Hugo currently applies only English typographic rules.
The Typographer extension already supports configuring substitution, but Hugo uses the default config and it does not expose the options to the user (
extensions.NewTypographer(opts ...TypographerOption)
).There's an existing Goldmark extension that can already configure the Typographer for different languages https://github.com/mdigger/goldmark-lang-typographer, but not using it and just allowing manual configuration for Typographer extension would be totally sufficient and probably more flexible.
As proof of concept, I implemented it with static global configuration. But, being able to configure different option for different languages and making it sensitive to page language would be much more interesting. Unfortunately, I have not figured out how to implement this yet.
Would be there any interest in including such feature in Hugo?
The text was updated successfully, but these errors were encountered: