Create a struct with all of Hugo's config options #10602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
force-pushed
the
feat/allconfig
branch
5 times, most recently
from
84a44d0
to
098b09e
Compare
bep
force-pushed
the
feat/allconfig
branch
2 times, most recently
from
ff96321
to
3ac7939
Compare
bep
force-pushed
the
feat/allconfig
branch
5 times, most recently
from
485aaef
to
44b38b0
Compare
bep
force-pushed
the
feat/allconfig
branch
2 times, most recently
from
d81ec87
to
1602b0e
Compare
bep
added a commit
to bep/hugo
that referenced
this pull request
Apr 12, 2023
Note that the config per language part of this will be handled in gohugoio#10602. Updates gohugoio#9772
bep
added a commit
to bep/hugo
that referenced
this pull request
Apr 12, 2023
Note that the config per language part of this will be handled in gohugoio#10602. Updates gohugoio#9772
bep
force-pushed
the
feat/allconfig
branch
4 times, most recently
from
424a86f
to
3bfc87e
Compare
bep
force-pushed
the
feat/allconfig
branch
21 times, most recently
from
a717ea5
to
78a2904
Compare
Primary motivation is documentation, but it will also hopefully simplify the code. Also, * Lower case the default output format names; this is in line with the custom ones (map keys) and how it's treated all the places. This avoids doing `stringds.EqualFold` everywhere. Closes gohugoio#10896 Closes gohugoio#10620
This was referenced May 20, 2023
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary motivation is documentation, but it will also hopefully simplify the code.
OK, this also ended up in a full and long needed restructuring of the commands package with end to end tests built with Go's
testscripts. Works great, much easier to reason about, but ... work.I'll list the commands here to help me get test coverage: