Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a --noBuildLock flag #9780

Closed
sftim opened this issue Apr 13, 2022 · 2 comments · Fixed by #9914
Closed

Add a --noBuildLock flag #9780

sftim opened this issue Apr 13, 2022 · 2 comments · Fixed by #9914
Labels
Enhancement Outdated
Milestone
v0.100.0

Comments

@sftim
Copy link

sftim commented Apr 13, 2022

For local development, the Kubernetes project runs Hugo in a container, with the website source mounted in read-only (there is a tmpfs that Hugo renders to).

Recent Hugo releases try to lock the source directory, which fails because of the read-only mount. I'd welcome a mechanism to bypass the lock file creation for the within-a-container case; we know it's actually safe to have Hugo try to run inside the container and to run outside it as well.
@bep bep changed the title Bypass lock file creation Add a --noLock flag Apr 13, 2022
@bep bep changed the title Add a --noLock flag Add a --noBuildLock flag Apr 13, 2022
@bep
Copy link
Member

bep commented Apr 13, 2022

You're not the first asking for something similar, so I guess we should do that. If someone is quick with a PR, I may get it in the 0.97 release...

@bep bep added this to the v0.97.0 milestone Apr 13, 2022
@bep bep modified the milestones: v0.97.0, v0.99.0 Apr 28, 2022
satotake added a commit to satotake/hugo that referenced this issue May 22, 2022
@satotake
basefs: add noBuildLock flag
d9c80f7 
If the flag is enabled, `.hugo_build.lock` will not be created.
This ensures safe running on read-only filesystem etc.
Close gohugoio#9780
@satotake satotake mentioned this issue May 22, 2022
Merged
@bep bep modified the milestones: v0.99.0, v0.100.0 May 24, 2022
@bep bep closed this as completed in #9914 May 24, 2022
bep pushed a commit that referenced this issue May 24, 2022
@satotake @bep
basefs: add noBuildLock flag
6f7fbe0 
If the flag is enabled, `.hugo_build.lock` will not be created.
This ensures safe running on read-only filesystem etc.
Close #9780
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Enhancement Outdated
Projects
None yet
Milestone
v0.100.0
Development

Successfully merging a pull request may close this issue.

basefs: add noBuildLock flag satotake/hugo
2 participants
@bep @sftim