Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/case insensitive glob walk #10327

Closed
wants to merge 2 commits into from

Conversation

bep
Copy link
Member

@bep bep commented Sep 26, 2022

  • resources: Refix resources.GetMatch/Match case-sensitivity bug
  • resources: resources: Simplify GetMatch fix

@satotake
Copy link
Contributor

Thanks for this.

First, for my own purpose, ca116e6 would be ok.

But considering #7686 (comment) , we need to be careful about

  • Even with this patch, the case mentioned in the comment would be failed because the case-unmatched pattern does not hit the image on Linux.
  • But the test passed. This is because false-positive (?) cache hit. Probably, it would fail if we change the order of the cases. I was trapped with this yesterday.

@bep
Copy link
Member Author

bep commented Sep 26, 2022

@satotake yea, well, I looked at the test, and that has more assumptions than the issue describes (I think):

  • The main issue is that mixed-case directories is not found.
  • Your test cases also considers FOO/bar.txt and foo/bar.txt to be different resources, which is something else.

I'm closing this for now and marking the bugs with a suitable label.

@bep bep closed this Sep 26, 2022
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants