-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tpl/tplimpl: Add img loading attribute to figure shortcode #10927
Conversation
to make it possible to e.g. to lazy load an figure/image
@jmooring this looks good to me, but I don't have strong opinions about this either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are already 12 parameters for the built-in figure shortcode: alt
, attr
, attrlink
, caption
, class
, height
, link
, rel
, src
, target
, title
, and width
.
This PR adds 7 new parameters, rendered as img
element attributes:
ismap
: very rareloading
: seems usefullongdesc
: deprecatedreferrerpolicy
: raresize
: invalidsrcset
: typically derived via image processing in renderhook, partial, or custom shortcodeusemap
: very rare
Remove everything but the loading attribute, and update the documentation (docs/content/en/content-management/shortcodes.md).
1798dc0d5 Update theme 403fa716e Update CLI documentation (#2092) aade5a09e Correct media subtype example 53cd9dea6 netlify: Hugo 0.112.3 b78b86cb1 Add source/target warning to resources.Copy (#2091) 50c299729 netlify: Hugo 0.112.2 73197046f Change config.xxx to hugo.xxx throughout the documentation (#2090) d489d4c6f Add hugo.WorkingDir to docs (#2089) 7487df809 Fix typos (#2088) 6d0572cd6 netlify: Hugo 0.112.1 6838600b2 netlify: Hugo 0.112.0 513e7a80f Merge branch 'tempv0.112.0' 91eb44275 Some more about 0.112.0 bd3b33a27 docs: Regen docshelper fb3027daf docs: Regen CLI docs 8e7b8e987 Merge commit 'f96384a3b596f9bc0a3a035970b09b2c601f0ccb' a942ceef4 tpl/tplimpl: Add img loading attribute to figure shortcode (#10927) 0e0c7b25e tpl/urls: Return empty string when JoinPath has zero args 310ce949a tpl/urls: Add JoinPath template function ae435ca77 tpl: Add math.Abs f340139f8 Revert "Update syntax-highlighting.md (#10929)" (#10930) 917a0e24d Update syntax-highlighting.md (#10929) git-subtree-dir: docs git-subtree-split: 1798dc0d54ce048dd975863b490cd809ef14268a
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
to make it possible to e.g. to lazy load an figure/image