Allow whitelisting mediaTypes used in resources.GetRemote #10973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
force-pushed
the
feat/sec-whiteliste-mediatype-10286
branch
4 times, most recently
from
b773fe8
to
3094777
Compare
bep
force-pushed
the
feat/sec-whiteliste-mediatype-10286
branch
from
3094777
to
66e4714
Compare
|
@jmooring I'm confident that it works, just wanted a second eye -- as this issue has confused me enough in the past. |
jmooring
reviewed
May 20, 2023
There was a problem hiding this comment.
LGTM. Tested protobuf example described in https://discourse.gohugo.io/t/43556, and made sure that "built-in" media types are not excluded when config doesn't include them.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10286