Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: Fix pkg is being imported more than once #11120

Closed
wants to merge 1 commit into from
Closed

all: Fix pkg is being imported more than once #11120

wants to merge 1 commit into from

Conversation

testwill
Copy link
Contributor

No description provided.

@bep
Copy link
Member

bep commented Jun 16, 2023

Thanks for this.

Can you fix the commit message to be in line with the guidelines?

@CLAassistant
Copy link

CLAassistant commented Jun 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@testwill testwill changed the title chore: pkg is being imported more than once all: fix pkg is being imported more than once Jun 16, 2023
@bep
Copy link
Member

bep commented Jun 16, 2023

https://github.com/gohugoio/hugo/blob/master/CONTRIBUTING.md#git-commit-message-guidelines

@testwill
Copy link
Contributor Author

Hello, I don't understand where the format is wrong

@bep
Copy link
Member

bep commented Jun 19, 2023

In the commit message title. It should start out with all: Fix ... (as in: a sentence starting out with an upper case character). I now I'm a little pedantic, and I could have saved us both some time by fixing it myself, but I do this hoping that this is the first of many contributions from you, so we might as well get it right starting out.

@testwill testwill changed the title all: fix pkg is being imported more than once all: Fix pkg is being imported more than once Jun 19, 2023
@testwill
Copy link
Contributor Author

ok, thanks

@bep
Copy link
Member

bep commented Jun 19, 2023

Also, it's the commit message title that's relevant, not the PR title.

@testwill
all: Fix pkg is being imported more than once
b4694a1 
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@testwill
Copy link
Contributor Author

ok, thanks

@alexandear
Copy link
Contributor

I did the fix in #10797

@testwill testwill closed this Jun 24, 2023
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
NeedsUserFeedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@testwill @bep @CLAassistant @alexandear