Print help message when command is triggered with no flags #11170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bep
reviewed
Jun 27, 2023
| @@ -110,6 +110,7 @@ See convert's subcommands toJSON, toTOML and toYAML for more information.` | |||
| cmd.PersistentFlags().StringVarP(&c.outputDir, "output", "o", "", "filesystem path to write files to") | |||
| cmd.PersistentFlags().BoolVar(&c.unsafe, "unsafe", false, "enable less safe operations, please backup first") | |||
|
|
|||
| cmd.RunE = nil | |||
There was a problem hiding this comment.
Can you explain the code above? I don't see the relevance to the issue title ...
|
I can confirm that the fix is effective and resolves #11165 . |
|
OK, thanks. I see it now. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix this issue.
Starting from release v0.112.0 and via this commit,
import,new,convert,listandgencommands produce no output when triggered with no flags.This PR reverts to the old behaviour by printing the help message by default.