Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markup/goldmark: add support for CJK extension #11356

Merged
merged 4 commits into from
Aug 30, 2023

Conversation

henry0312
Copy link
Contributor

This commit fixes #10472.

To make this PR function more accurately, merging yuin/goldmark#409 is needed.

@CLAassistant
Copy link

CLAassistant commented Aug 13, 2023

CLA assistant check
All committers have signed the CLA.

@henry0312
Copy link
Contributor Author

henry0312 commented Aug 18, 2023

goldmark v1.5.6 has been released (cf. #11365).
The features implemented in the pull request work fine, and it is ready for merging.

@bep bep self-assigned this Aug 23, 2023
@bep bep added this to the v0.118.0 milestone Aug 23, 2023
@bep
Copy link
Member

bep commented Aug 23, 2023

Thanks, this looks good.

I do, however, notice that there are 2 additional options on this extension:

https://github.com/yuin/goldmark#cjk-extension

I assume someone will ask for these at some point, so I think we might as well make the new config option a map, e.g.:

[markup]
[markup.goldmark]
[markup.goldmark.extensions.CJK]
enable=false
eastAsianLineBreaks=false
escapedSpace=false

@henry0312
Copy link
Contributor Author

I updated and added two options.
At first, I anticipated that those who want to enable the CJK option would also want to enable the eastAsianLineBreaks and escapedSpace features simultaneously.
However, I now believe that making those two options certainly provides more flexibility.

@bep
Copy link
Member

bep commented Aug 30, 2023

Thanks, I will merge once the tests go green.

A side note for future reference; the docs.yaml file is autogenerated (I do it before a new release) so any manual edits will be overwritten (which is why it doesn't matter much ...).

@bep bep merged commit d7dcc76 into gohugoio:master Aug 30, 2023
8 checks passed
@henry0312 henry0312 deleted the add_cjk_extension branch August 30, 2023 23:48
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add goldmark's CJK extension support
3 participants