-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
markup/goldmark: add support for CJK extension #11356
Conversation
This commit fixes gohugoio#10472.
Thanks, this looks good. I do, however, notice that there are 2 additional options on this extension: https://github.com/yuin/goldmark#cjk-extension I assume someone will ask for these at some point, so I think we might as well make the new config option a map, e.g.: [markup]
[markup.goldmark]
[markup.goldmark.extensions.CJK]
enable=false
eastAsianLineBreaks=false
escapedSpace=false |
I updated and added two options. |
Thanks, I will merge once the tests go green. A side note for future reference; the docs.yaml file is autogenerated (I do it before a new release) so any manual edits will be overwritten (which is why it doesn't matter much ...). |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This commit fixes #10472.
To make this PR function more accurately, merging yuin/goldmark#409 is needed.