Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpl/tplimpl: Update RSS template #12300

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Conversation

jmooring
Copy link
Member

  • Use publication date for pubdate
  • Include version in generator element

Closes #3918
Closes #11692

- Use publication date for pubdate
- Include version in generator element

Closes gohugoio#3918
Closes gohugoio#11692
@bep bep merged commit f0a26cf into gohugoio:master Mar 30, 2024
8 checks passed
@jmooring jmooring deleted the update-rss-template branch March 30, 2024 18:56
@johnweldon
Copy link
Contributor

fwiw, it doesn't appear that PublishDate falls back to Date if it's not set - at least not for Categories and Tags.

@jmooring
Copy link
Member Author

@johnweldon If you think there's a bug, log a bug.

@thc202
Copy link

thc202 commented Apr 22, 2024

Would be possible to have the version optional? We serve the site through GitHub Pages which lives in its own repo, with the version change we end up with unnecessary pull requests just updating the version (e.g.: https://github.com/zaproxy/zaproxy.github.io/pull/1425/files).

@schu
Copy link

schu commented Apr 26, 2024

it doesn't appear that PublishDate falls back to Date if it's not set - at least not for Categories and Tags.

I noticed this as well and opened an issue here: #12438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hugo version to RSS </generator> RSS template should use PublishDate
5 participants