tpl/tplimpl: Improve embedded opengraph template #12328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmooring
force-pushed
the
improve-opengraph
branch
from
5b09b3f
to
025f11f
Compare
bep
reviewed
Apr 2, 2024
|
|
||
| {{- range .GetTerms "series" }} | ||
| {{- range .Pages | first 7 }} | ||
| {{- if not ($.Eq .) }} |
There was a problem hiding this comment.
I would prefer if we use eq and similar for equality checks. It's not like .Eq is going away, but it was added plainly to make eq work with wrapped page types.
There was a problem hiding this comment.
I've made the change. Let me know if I should remove PAGE.Eq from the docs. I guess I like the syntax, but I really don't care either way.
There was a problem hiding this comment.
My take on this is that
eqcan be used with (almost) any Hugo object/type..Eqis only available on some types, so it's less portable and will break if people expect it to work on ... say strings.
jmooring
force-pushed
the
improve-opengraph
branch
from
025f11f
to
78fb3e1
Compare
Changes: - Add tags per documentation - Prefer site.Title over site.Params.title - Plainify titles, tags, and descriptions - Add fallback values for locale - Fix pages related by series - Improve readability Closes gohugoio#8296 Closes gohugoio#8698 Closes gohugoio#8991 Closes gohugoio#9818 Closes gohugoio#9866 Closes gohugoio#10647 Co-authored-by: tomy0000000 <git@tomy.me> Co-authored-by: sean-au <sean@powerfulwebdesign.com.au>
jmooring
force-pushed
the
improve-opengraph
branch
from
78fb3e1
to
53758c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Closes #8296
Closes #8698
Closes #8991
Closes #9818
Closes #9866
Closes #10647