Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/hexec: Fall back to the binary in PATH if npx fails #12616

Merged
merged 1 commit into from
Jun 22, 2024
+11 −1
Merged

common/hexec: Fall back to the binary in PATH if npx fails #12616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion common/hexec/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,18 @@ func (e *Exec) New(name string, arg ...any) (Runner, error) {
return cm.command(arg...)
}

// Npx is a convenience method to create a Runner running npx --no-install <name> <args.
// Npx will try to run npx, and if that fails, it will
// try to run the binary directly.
func (e *Exec) Npx(name string, arg ...any) (Runner, error) {
r, err := e.npx(name, arg...)
if err == nil {
return r, nil
}
return e.New(name, arg...)
}

// npx is a convenience method to create a Runner running npx --no-install <name> <args.
func (e *Exec) npx(name string, arg ...any) (Runner, error) {
arg = append(arg[:0], append([]any{"--no-install", name}, arg[0:]...)...)
return e.New("npx", arg...)
}
Expand Down
Loading