Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

css.TailwindCSS etc. #12619

Merged
merged 2 commits into from
Jun 25, 2024
Merged

css.TailwindCSS etc. #12619

merged 2 commits into from
Jun 25, 2024

Conversation

bep
Copy link
Member

@bep bep commented Jun 23, 2024

  • Clean up the css related template funcs package structure
  • Add css.TailwindCSS

@bep bep mentioned this pull request Jun 23, 2024
Draft
2 tasks
@jmooring
Copy link
Member

When I use the toCSS alias instead of css.SASS I get a deprecation warning. I assume (but have not tested) that the same will happen with the postCSS and babel aliases.

Do these need to be mapped to the new namespace?

@bep
Copy link
Member Author

bep commented Jun 23, 2024

When I use the toCSS alias instead of css.SASS I get a deprecation warning.

Good catch. I need to move the aliases to the new packages.

@bep bep force-pushed the feat/tailwind-12618 branch 10 times, most recently from 4ff06a0 to 4e2f687 Compare June 25, 2024 13:04
@bep bep marked this pull request as ready for review June 25, 2024 13:05
bep added 2 commits June 25, 2024 15:18
@bep
Clean up the css related template funcs package structure
6954756 
Deprecate and move:

* resources.ToCSS => css.SASS
* resources.PostProcess => css.PostProcess
* resources.Babel => js.Babel

Updates gohugoio#12618
@bep
Add css.TailwindCSS
9ee33ef 
Closes gohugoio#12618
Closes gohugoio#12620
@bep bep changed the title css.TailwinCSS etc. css.TailwindCSS etc. Jun 25, 2024
@bep bep merged commit e1317dd into gohugoio:master Jun 25, 2024
7 checks passed
@cjshearer
Copy link

Regarding the documentation for https://gohugo.io/functions/css/tailwindcss/, there doesn't seem to be any reason css.TailwindCSS must use v4. I've got an example of replacing all my package.json/npm stuff with tailwindcss 3.4.4's standalone cli working here. I even found a workaround for supplying a custom, extendable tailwind config from a theme!

@bep
Copy link
Member Author

bep commented Jun 26, 2024

there doesn't seem to be any reason css.TailwindCSS must use v4.

That is true, but (some of) the options listed are v4 only, and that was the mindset/motivation when adding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bep @jmooring @cjshearer