Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create/skeletons: Fix languageCode region subtag #12631

Merged
merged 1 commit into from
Jul 2, 2024
Merged

create/skeletons: Fix languageCode region subtag #12631

merged 1 commit into from
Jul 2, 2024

Conversation

CyrusYip
Copy link
Contributor

Region subtag should be in ALLCAPS

@CyrusYip
create/skeletons: Fix languageCode region subtag
286fc4d 
Region subtag should be in ALLCAPS
@CLAassistant
Copy link

CLAassistant commented Jun 29, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CyrusYip
Copy link
Contributor Author

CyrusYip commented Jul 1, 2024

Reference:

  • Region subtag

    Optional. This subtag defines a dialect of the base language from a particular location, and is either 2 letters in ALLCAPS matching a country code, or 3 numbers matching a non-country area. For example, es-ES is for Spanish as spoken in Spain, and es-013 is Spanish as spoken in Central America. "International Spanish" would just be es.
    —lang - HTML: HyperText Markup Language | MDN

@bep bep requested a review from jmooring July 1, 2024 14:21
jmooring
jmooring approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@jmooring jmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bep bep added the Merge label Jul 1, 2024
@bep bep merged commit a95fe50 into gohugoio:master Jul 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmooring jmooring jmooring approved these changes

Assignees
No one assigned
Labels
Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CyrusYip @CLAassistant @jmooring @bep