Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpl/tplimpl: trim descriptions rather than just chomp #12901

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Oct 2, 2024

This PR proposes that we trim whitespace from both ends of descriptions rather than just chomp.

A bit of context for this change: since upgrading to Hugo 0.135.0, opentelemetry.io many page descriptions have been padded with (IMHO unnecessary) whitespace. If the Hugo templates are chomping the description text, it might as well just trim both ends of any whitespace, right? :)

/cc @svrnm @theletterf

@theletterf
Copy link

Zen and the Art of Hugo Bonsai Pruning! Like it!

@bep bep requested a review from jmooring October 10, 2024 19:20
Copy link
Member

@jmooring jmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bep bep merged commit 0398458 into gohugoio:master Oct 12, 2024
5 checks passed
@chalin chalin deleted the chalin-im-desc-trim-2024-10-02 branch October 15, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants