Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources: Address Dart Sass deprecation of global built-in functions #12966

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

jmooring
Copy link
Member

@jmooring
Copy link
Member Author

jmooring commented Oct 19, 2024

#12961 (comment)

I guess adding some kind of identifier as the first arg to CreateVarsStyleSheet would solve it.

To avoid hardcoded identifiers, I moved the constant declarations from the tpl/css package to the sass package, which was previously an "internal" package. I had to make it "not internal" in order to export the constants.

@jmooring jmooring force-pushed the dart-sass-warning-12961 branch from c063f83 to 9a723a2 Compare October 19, 2024 15:53
@bep bep added this to the v0.137.0 milestone Oct 31, 2024
@bep bep force-pushed the dart-sass-warning-12961 branch from 9a723a2 to c1707ab Compare November 1, 2024 12:38
@bep bep merged commit 889308d into gohugoio:master Nov 1, 2024
6 checks passed
@jmooring jmooring deleted the dart-sass-warning-12961 branch November 1, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dart Sass v1.80.1 deprecation warning
2 participants