Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yulinling.net to showcase #1429

Closed
wants to merge 2 commits into from
Closed

Add yulinling.net to showcase #1429

wants to merge 2 commits into from

Conversation

Lynxiayel
Copy link
Contributor

I added yulinling.net, my blog, to the showcase, the related source code (removing private info) is also included.
Plz review and merge, thanks.

@anthonyfok anthonyfok self-assigned this Sep 14, 2015
@anthonyfok
Copy link
Member

Hello @Lynxiayel,

Thank you for your contribution!

I needed to make the following modifications:

  • Remove leading + characters on each line of docs/content/showcase/yulinling.net.md
  • Correct the thumbnail filename listed in yulinling.net.md (png → jpg)
  • Add Chinese name "语林灵" to yulinling.net.md
  • Recapture and resize your thumbnail image to 600x400.

Also, it is preferable to create your pull request from a topic branch, not from master, as now you would need to use git pull --rebase or something similar to get your local master branch to match that of upstream. 😉

Merged as 68b8dd7 (master) and 19a7aa9 (v0.14.docs).

再次感谢!很高兴见到越来越多中文网站使用 Hugo。 😉

Anthony

@anthonyfok anthonyfok closed this Sep 14, 2015
@Lynxiayel
Copy link
Contributor Author

Oh thanks a lot, that's much useful information for me as a rookie :)

@anthonyfok
Copy link
Member

Oh, one more problem which I fixed in a second commit...

(CSS and images won't load for https)

Next time, try to test it before you submit the pull request. 😉
You may test your change to Hugo docs locally by using this command:

hugo -s docs server

and then opening http://localhost:1313/showcase/ on your web browser.

@Lynxiayel
Copy link
Contributor Author

@anthonyfok Thank you, it's nice to know :)

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants