Be less aggressive with CHMOD filesystem events #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On 4679fbe, rebuild was disabled on CHMOD filesystem events, but the code is overly aggressive. In some situations, specially with older Mac's (using a Late 2008 Macbook), the events we receive might be aggregated. On my particular laptop, I get this events: INFO: 2016/07/26 18:08:51 hugo.go:737: Received System Events: ["<path>": WRITE|CHMOD] These events are ignored because the code only checks for Chmod. This commit fixes this by checking that the event is also not a Write or Create. Related to gohugoio#1587.
|
Don't worry about the tests -- I know how painful it is to write file system events tests (see https://github.com/fsnotify/fsnotify/blob/master/integration_darwin_test.go#L22 for a test I wrote to simulate atomic writes on OS X); Hugo's problem is that it must support lots of editors, and it is impossible (or very hard) to test them all ... |
|
Thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 4679fbe, rebuild was disabled on CHMOD filesystem events, but the code is overly aggressive.
In some situations, specially with older Mac's (using a Late 2008 Macbook), the events we receive might be aggregated. On my particular laptop, I get this events:
These events are ignored because the code only checks for Chmod. This commit fixes this by checking that the event is also not a Write or Create.
Related to #1587.
This is my first contribution to any Go project, so please forgive any Go-newbiness going on. Any comments are appreciated.
I also don't know how to write tests about this. I don't see a
hugo_test.goand frankly I don't know how to simulate filesystem events to reproduce this. I do know that Hugo now rebuilds correctly on these events on my slow Mac :). Help is appreciated here.Thank you,