-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Node a Page #2649
Make Node a Page #2649
Conversation
fb38bf0
to
53ebb33
Compare
220fc56
to
0cc62bc
Compare
The tests are all green -- and this actually works now. Still many loose ends to tie, but it looks promising. And faster:
|
f22ff54
to
0dc9c77
Compare
Removing the This compares Hugo
|
And embed that on Page. Updates gohugoio#2297
Having a custom string type isn't worth it when it doesn't work with `where`, `eq` etc. Fixes gohugoio#2689 Updates gohugoio#2297
And misc. TODO-fixes Updates gohugoio#2297
This includes removing the error return value from Permalink and RelPermalink. We ignore that error all over the place, so we might as well remove it. Updates gohugoio#2297
By embeding the init sync.Once var in a pointer so we can reset it when we copy the page. Updates gohugoio#2297
Returning all types is both confusing and too breaking. All page types can be fetched in .Site.Pages. Updates gohugoio#2297
Some sites, Hugo docs included, have faulty alias definitions that point to itself or another real page. These will be overwritten in the next step. This is how it behaves in Hugo 0.17, too. Updates gohugoio#2297
Because it is the right solution and it the avoids naming conflict with section vs page. Updates gohugoio#2297
Was removed by mistake. Updates gohugoio#2297
And some other minor doc fixes. Closes gohugoio#2297 Closes gohugoio#2649
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
GetPage(NodeType, path...)
onSiteInfo
or similar ..._index.md
AllNodes
?where
vsNodeType
TODO(bep) np
PageType
=>Kind
_index.md
++
Fixes #2297