-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extras/shortcodes: Add Reuse Page Shortcode concept #3231
Conversation
@savsheniuk, |
@moorereason Oh, yes. You are right :( Thanks a lot 👍 |
20e543e
to
7b118b3
Compare
Hey and welcome to Hugo devs, @savsheniuk ! I have read your code, and it looks solid. So, I understand that you are a good developer. But I'm not sure how this fits into the "vision" #3205, and the quantity of changes tell me that I don't want to commit to this right now. I would probably have preferred to make it simpler:
But even with those simplifications, I'm hesitant at the moment. But what would have been a good idea, and I feel it would solve the same problem, would be some kind of caching internal decorator shortcode, so I would do something like this:
Where |
Thanks, @bep . I understand your concern. |
92cb5f0
to
f4ea163
Compare
Add a Reuse Page shortcode that allows tech writers to reuse same pages in different places without need in copy-pasting them every time. It also adds a concept of Page snippets and dynamic links resolution.
f4ea163
to
d5f71e1
Compare
Fixed the first point: new parameter "issnippet=true" can be specified inside the front-matter to mark the page as a snippet. |
I will close this as I think this is too big a change for what it is. Most of this will be gained from #3612 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Add a Reuse Page shortcode that allows tech writers to reuse same pages in different places without need in copy-pasting them every time.
It also adds a concept of Page snippets and dynamic links resolution.