-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for multiple config files via --config a.toml,b.toml,c.toml #3532
Conversation
…toml,another.toml Use viper's MergeConfig() to merge changes go fmt update
3 things:
|
It seems I have done the CLA ?? |
I don't see, what you signed the CLA too |
@jgielstra then I think there is a mismatch between your commit email and the email you have registered on your GitHub account. You can add multiple email addresses in your GH profile to handle this issue. |
Thx that was indeed the case .. |
@jgielstra sorry about letting this drag out; it is maybe because of the move to a GitHub org, but the CLA still shows up as "not signed". |
I have another work account.. I commited under that account to my personal github repo siiiigh.
Please excuse the goose chase..
…-Johan
On Jul 22, 2017, at 1:00 PM, Bjørn Erik Pedersen ***@***.***> wrote:
@jgielstra <https://github.com/jgielstra> sorry about letting this drag out; it is maybe because of the move to a GitHub org, but the CLA still shows up as "not signed".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#3532 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIEAsoTn-QelPsBGMwajwq8NylTexFG9ks5sQjjRgaJpZM4NoAGr>.
|
@spf13 @moorereason @digitalcraftsman and others: This seems like a great addition and I cannot think of a reason why this should bite us in the ass in the future? |
I like the idea of @jgielstra. But I would like to turn the spotlight #3090 as well. It proposes to optionally externalize the site config into the data folder. This goes somewhere in the same direction. In #3090 we literally split up a config file in smaller pieces. Using I just want to make sure we can incorporate both approaches. |
@jgielstra I have merged this, but it would also be nice to have a line or two in the documentation somewhere about this, and a PR for that (in this repo) would be welcomed. |
Is this feature still undocumented? If so we should open an issue for it. |
Yes. Lesson learned: Never merge PRs without doc. |
I've opened an issue as a reminder to document it. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Our team needs multiple configs for the same doc site to support different delivery channels.
We'd like to have a base config.toml and one or more child config.tomls overriding properties in the config.
I didn't see support for repeating command-line options in Cobra.
I've added the ability pass multiple config files via
--config
as a comma delimited string.For example:
hugo --config=base.toml,child1.toml,child2.toml
Use viper's MergeConfig() to merge changes.