Internal Shortcodes: vimeo_simple + vimeo (default) #4787
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work of @bep see: 448081b
Related issue: #4749
Added the following:
__h_simple_assets.html
and changed the classes prefix to__h_video
since this is meant to be used in both Vimeo and (hopefully) YouTube simple shortcodes.border: 0;
and removed the 30px top-margin from the inline style.N.B.
I was unable to have these changes reflected in a compiled binary. I think I'm missing something. I was able to run
mage generate
but still I didn't see anything new when I rungo build
.I was only able to test these shortcodes locally when I included them in a Hugo project.
So this PR needs to be tested some more.