Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Livereload CSS and images without browser refresh #490

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions commands/hugo.go
Original file line number Diff line number Diff line change
Expand Up @@ -312,10 +312,11 @@ func NewWatcher(port int) error {

static_changed := false
dynamic_changed := false
static_files_changed := make(map[string]bool)

for _, ev := range evs {
ext := filepath.Ext(ev.Name)
istemp := strings.HasSuffix(ext, "~") || (ext == ".swp") || (ext == ".tmp")
istemp := strings.HasSuffix(ext, "~") || (ext == ".swp") || (ext == ".tmp") || (strings.HasPrefix(ext, ".goutputstream"))
if istemp {
continue
}
Expand All @@ -328,6 +329,12 @@ func NewWatcher(port int) error {
static_changed = static_changed || isstatic
dynamic_changed = dynamic_changed || !isstatic

if isstatic {
if staticPath, err := helpers.MakeStaticPathRelative(ev.Name); err == nil {
static_files_changed[staticPath] = true
}
}

// add new directory to watch list
if s, err := os.Stat(ev.Name); err == nil && s.Mode().IsDir() {
if ev.IsCreate() {
Expand All @@ -342,7 +349,16 @@ func NewWatcher(port int) error {

if !viper.GetBool("DisableLiveReload") {
// Will block forever trying to write to a channel that nobody is reading if livereload isn't initalized
livereload.ForceRefresh()

// force refresh when more than one file
if len(static_files_changed) == 1 {
for path := range static_files_changed {
livereload.RefreshPath(path)
}

} else {
livereload.ForceRefresh()
}
}
}

Expand Down
23 changes: 23 additions & 0 deletions helpers/helpers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,3 +122,26 @@ func TestMakePermalink(t *testing.T) {
}
}
}

func TestMakePathRelative(t *testing.T) {
type test struct {
inPath, path1, path2, output string
}

data := []test{
{"/abc/bcd/ab.css", "/abc/bcd", "/bbc/bcd", "/ab.css"},
{"/abc/bcd/ab.css", "/abcd/bcd", "/abc/bcd", "/ab.css"},
}

for i, d := range data {
output, _ := MakePathRelative(d.inPath, d.path1, d.path2)
if d.output != output {
t.Errorf("Test #%d failed. Expected %q got %q", i, d.output, output)
}
}
_, error := MakePathRelative("a/b/c.ss", "/a/c", "/d/c", "/e/f")

if error == nil {
t.Errorf("Test #%d failed. Expected error")
}
}
18 changes: 18 additions & 0 deletions helpers/path.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
package helpers

import (
"errors"
"fmt"
"io"
"os"
Expand Down Expand Up @@ -130,6 +131,23 @@ func AbsPathify(inPath string) string {
return filepath.Clean(filepath.Join(viper.GetString("WorkingDir"), inPath))
}

func MakeStaticPathRelative(inPath string) (string, error) {
staticDir := AbsPathify(viper.GetString("StaticDir"))
themeStaticDir := AbsPathify("themes/"+viper.GetString("theme")) + "/static/"

return MakePathRelative(inPath, staticDir, themeStaticDir)
}

func MakePathRelative(inPath string, possibleDirectories ...string) (string, error) {

for _, currentPath := range possibleDirectories {
if strings.HasPrefix(inPath, currentPath) {
return strings.TrimPrefix(inPath, currentPath), nil
}
}
return inPath, errors.New("Can't extract relative path, unknown prefix")
}

func Filename(in string) (name string) {
name, _ = FileAndExt(in)
return
Expand Down
7 changes: 6 additions & 1 deletion livereload/livereload.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,12 @@ func Initialize() {

func ForceRefresh() {
// Tell livereload a js file changed to force a hard refresh
wsHub.broadcast <- []byte(`{"command":"reload","path":"/x.js","originalPath":"","liveCSS":true}`)
RefreshPath("/x.js")
}

func RefreshPath(s string) {
// Tell livereload a file has changed - will force a hard refresh if not CSS or an image
wsHub.broadcast <- []byte(`{"command":"reload","path":"` + s + "\"" + `,"originalPath":"","liveCSS":true,"liveImg":true}`)
}

func ServeJS(w http.ResponseWriter, r *http.Request) {
Expand Down