Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix highlight sc so that it removes shortcode offset from inner code #5553

Closed

Conversation

kaushalmodi
Copy link
Contributor

Fixes #4717.

Fixes gohugoio#4717.

Add a test case showing offset removal in the highlight shortcode.
@kaushalmodi
Copy link
Contributor Author

@bep When you get a chance please review this PR.

  • It passes all the existing tests.
  • It passes the new test added specifically to test to fix. I have verified locally that if I revert the fix, this new test starts failing.

@bep
Copy link
Member

bep commented Dec 22, 2018

@kaushalmodi I appreciate the effort, but

  1. I need to understand this problem, which is a post-Christmas activity
  2. We cannot have logic at this level in the shortcode templates. If so, that would have required a different level of test coverage

In the mean time, I suggest you put this shortcode inside your own project(s).

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indented highlight shortcode brings in the indentation as part of the code block
2 participants