Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdownify template filter #652

Closed
wants to merge 1 commit into from

Conversation

bep
Copy link
Member

@bep bep commented Nov 18, 2014

Note that this is a Markdownify filter, and is named as such; it's not a
Asciidoc filter or in any direct way connected to a Page.

Fixes #524

@bep
Copy link
Member Author

bep commented Nov 18, 2014

This works fine for my use cases; the only issue I see is using some of the Markdown syntax on the title field, as that is also used in the title tag on the page, and that is plain text. But I see no easy way around that.

This has no connection to Page (and Page's content type) and I guess that's correct.

I can add some doc to this once I know it will get merged.

@bep
Copy link
Member Author

bep commented Nov 24, 2014

OK - I see a part got lost in the rebase ... will add.

@spf13
Copy link
Contributor

spf13 commented Nov 24, 2014

Will merge once you give the go ahead.

Note that this is a Markdownify filter, and is named as such; it's not a Asccidoc filter or in any way connected to a Page.

Fixes gohugoio#524
@bep
Copy link
Member Author

bep commented Nov 24, 2014

@spf13 Fixed and tested now. On a related note, I have tested your latest commits and it looks good (also related to the discussion about the summaries).

bep added a commit to bep/hugo that referenced this pull request Nov 24, 2014
This small function feels important enough to maybe deserve more than these three lines, but this will have to do for now.

This assumes that gohugoio#652 gets merged.
@bep bep mentioned this pull request Nov 24, 2014
@spf13
Copy link
Contributor

spf13 commented Nov 25, 2014

Merged as 53c707b

@spf13 spf13 closed this Nov 25, 2014
spf13 pushed a commit that referenced this pull request Nov 25, 2014
This small function feels important enough to maybe deserve more than these three lines, but this will have to do for now.

This assumes that #652 gets merged.
@bep bep deleted the feature/markdownify branch April 18, 2017 09:19
tychoish pushed a commit to tychoish/hugo that referenced this pull request Aug 13, 2017
This small function feels important enough to maybe deserve more than these three lines, but this will have to do for now.

This assumes that gohugoio#652 gets merged.
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Markdown in front matter
2 participants