-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add markdownify template filter #652
Conversation
This works fine for my use cases; the only issue I see is using some of the Markdown syntax on the title field, as that is also used in the title tag on the page, and that is plain text. But I see no easy way around that. This has no connection to Page (and Page's content type) and I guess that's correct. I can add some doc to this once I know it will get merged. |
691c5cf
to
ad109a8
Compare
OK - I see a part got lost in the rebase ... will add. |
Will merge once you give the go ahead. |
Note that this is a Markdownify filter, and is named as such; it's not a Asccidoc filter or in any way connected to a Page. Fixes gohugoio#524
ad109a8
to
09bbd32
Compare
@spf13 Fixed and tested now. On a related note, I have tested your latest commits and it looks good (also related to the discussion about the summaries). |
This small function feels important enough to maybe deserve more than these three lines, but this will have to do for now. This assumes that gohugoio#652 gets merged.
Merged as 53c707b |
This small function feels important enough to maybe deserve more than these three lines, but this will have to do for now. This assumes that #652 gets merged.
This small function feels important enough to maybe deserve more than these three lines, but this will have to do for now. This assumes that gohugoio#652 gets merged.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Note that this is a Markdownify filter, and is named as such; it's not a
Asciidoc filter or in any direct way connected to a Page.
Fixes #524