Added Images to sitemap.xml

[derekperkins]

#655 This is dependent on image metadata being standardized as discussed at http://discuss.gohugo.io/t/hugo-seo-social-partials/353/17

[derekperkins]

I just added a commit to address issue #653 about excluding pages from the sitemap.

[spf13]

@derekperkins I know you've been waiting a while on this one. Sorry it took me so long to get to it. It looks real nice. Merged as 3c147bd

[derekperkins]

No problem. There have been plenty of other fish to fry. :)

[spf13]

@derekperkins

Now that this and the other PR have been merged can you add these new standards to the documentation?

We've gotten a bug report #972 about the sitemap being broken, but the problem isn't the template, but that the user had params.images as a string, here you expect it to have sub fields.

We also should probably adjust the template to handle allowing users to just make params.images as a slice of strings.

[bep]

Have a look at the template_embedded.go that uses .Params.images and expects it to be a slice of strings -- so this is not "a user that ...".

I suggest a revert of the above commit -- and do a rethinking and doc job of the complete picture.

[derekperkins]

There was a discussion started about standardizing metadata like images, but no conclusions were ever reached. I think we should make params.images something that we can expect. Somewhere I believe I submitted a PR that added Images as first class citizens to Node objects, or at least I thought about it. It's been a few months since I've done anything with Hugo.

[bep]

Closing this for now. Open a new one when we figure out what we want.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.