Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to exec arbitrary commands from templates. #847

Closed
wants to merge 5 commits into from

Conversation

aliafshar
Copy link

No description provided.

@aliafshar aliafshar mentioned this pull request Jan 27, 2015
@spf13
Copy link
Contributor

spf13 commented Feb 18, 2015

I'm still worried about this. I'm punting on this until after the v0.13 release is out. I'm thinking more of having a few dedicated exec based functions... like "grep"... but then concerned about how it would work with systems like windows which don't have them available.

@yml
Copy link

yml commented Oct 27, 2015

@spf13 I understand the security concern but I think that a reasonable middleground would be to use a whitelist coming from the datafiles or the global config to restrict the binaries that can be called.

Does it sounds acceptable ?

@bep
Copy link
Member

bep commented Oct 27, 2015

@yml the datafiles can also be set in themes. So any white list would have to live in global config.

@yml
Copy link

yml commented Oct 27, 2015

@bep good call. Would checking the exec_whitelist in the global config be enough to let this feature get in.

@moorereason
Copy link
Contributor

Closing this PR as we won't be merging, as is. Lacks safeguards. The security issues needs more thought and discussion.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants