Fix Truncate #881
Closed
Fix Truncate #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TruncateWordsToWholeSentence knows if the summary is truncated, so let "him" decide. Fixes gohugoio#880
|
@anthonyfok could you have a look at this and merge if you agree?. I have tested it and In my eyes this should fix it. |
|
Brilliant, @bep! That does it! My local "Nitro" test page now correctly returns And thank you so much for fixing it so quickly! I am deep in some paperwork + babysitting my little ones + sleep deprivation, not in the right mind to do any sort of debugging, and was thinking "let's leave it for v0.14", so your quick turnaround time is a pleasant surprise to me. Thank you! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TruncateWordsToWholeSentence knows if the summary is truncated, so let "him" decide.
Fixes #880