Correct initialisms as suggested by golint

[anthonyfok]

First step to use initialisms that golint suggests, for example:

Line 116: func GetHtmlRenderer should be GetHTMLRenderer

as see on http://goreportcard.com/report/spf13/hugo

Thanks to @bep for the idea!

Note that command-line flags (cobra and pflag) as well as struct fields like .BaseUrl and .Url that are used in Go HTML templates need more work to maintain backward-compatibility, and thus are NOT yet dealt with in this commit.

First step in fixing #959.

[anthonyfok]

For the sake of full disclosure 😉, this is the script that I used with gofmt to do the bulk of the conversion. Note the exit near the end, i.e. the final for loop for BaseUrl and Url is not executed.

#!/bin/bash

for rule in \
    'baseUrl -> baseURL' \
    'oldBaseUrl -> oldBaseURL' \
    'fixUrl -> fixURL' \
    'pUrl -> pURL' \
    'refUrl -> refURL' \
    'remoteUrlLock -> remoteURLLock' \
    'UrlLock -> URLLock' \
    'UrlUnlock -> URLUnlock' \
    'absUrlInit -> absURLInit' \
    'absurlMatcher -> absURLMatcher' \
    'absurlReplacer -> absURLReplacer' \
    'BenchmarkAbsUrl -> BenchmarkAbsURL' \
    'BenchmarkXmlAbsUrl -> BenchmarkXMLAbsURL' \
    'dqHtmlMatch -> dqHTMLMatch' \
    'sqHtmlMatch -> sqHTMLMatch' \
    'dqXmlMatch -> dqXMLMatch' \
    'sqXmlMatch -> sqXMLMatch' \
    'dqHtml -> dqHTML' \
    'sqHtml -> sqHTML' \
    'dqXml -> dqXML' \
    'sqXml -> sqXML' \
    'TestAbsUrl -> TestAbsURL' \
    'TestFixUrl -> TestFixURL' \
    'TestXMLAbsUrl -> TestXMLAbsURL' \
    'CliBaseUrl -> CLIBaseURL' \
    'CfgBaseUrl -> CfgBaseURL' \
    'DocumentId -> DocumentID' \
    'PlainIdAnchors -> PlainIDAnchors' \
    'UniqueId -> UniqueID' \
    'uniqueId -> uniqueID' \
    'replaceInHtml -> replaceInHTML' \
    'replaceInXml -> replaceInXML' \
    'SafeCss -> SafeCSS' \
    'SafeHtml -> SafeHTML' \
    'SafeHtmlAttr -> SafeHTMLAttr' \
    'SafeUrl -> SafeURL' \
    'paginationUrlFactory -> paginationURLFactory' \
    'newPaginationUrlFactory -> newPaginationURLFactory' \
    'CanonifyUrls -> CanonifyURLs' \
    'canonifyUrls -> canonifyURLs' \
    'PrettifyUrl -> PrettifyURL' \
    'PrettifyUrlPath -> PrettifyURLPath' \
    'SanitizeUrl -> SanitizeURL' \
    'SanitizeUrlKeepTrailingSlash -> SanitizeURLKeepTrailingSlash' \
    'sanitizeUrlWithFlags -> sanitizeURLWithFlags' \
    'Urlize -> URLize' \
    'UrlizeAndPrep -> URLizeAndPrep' \
    'UrlPrep -> URLPrep' \
    'UglyUrls -> UglyURLs' \
    'uglyUrls -> uglyURLs' \
    'TestSafeCss -> TestSafeCSS' \
    'TestSafeHtml -> TestSafeHTML' \
    'TestSafeHtmlAttr -> TestSafeHTMLAttr' \
    'TestSafeUrl -> TestSafeURL' \
    'GoHtmlTemplate -> GoHTMLTemplate' \
    'GetHtmlRenderer -> GetHTMLRenderer' \
    'tstHtmlContent -> tstHTMLContent' \
    'menuEntryUrl -> menuEntryURL' \
    'menuEntryXml -> menuEntryXML' \
    'menuId -> menuID' \
    'findTestMenuEntryById -> findTestMenuEntryByID' \
    'removeTomlIdentifier -> removeTOMLIdentifier' \
    'HandleJsonMetaData -> HandleJSONMetaData' \
    'HandleTomlMetaData -> HandleTOMLMetaData' \
    'HandleYamlMetaData -> HandleYAMLMetaData' \
    'TestDataDirJson -> TestDataDirJSON' \
    'TestDataDirYamlWithOverridenValue -> TestDataDirYAMLWithOverridenValue' \
    'tstCreateMenuPageWithNameToml -> tstCreateMenuPageWithNameTOML' \
    'tstCreateMenuPageWithIdentifierToml -> tstCreateMenuPageWithIdentifierTOML' \
    'tstCreateMenuPageWithNameYaml -> tstCreateMenuPageWithNameYAML' \
    'tstCreateMenuPageWithIdentifierYaml -> tstCreateMenuPageWithIdentifierYAML' \
    'GetJson -> GetJSON' \
    'GetCsv -> GetCSV' \
    'parseCsv -> parseCSV' \
    'TestParseCsv -> TestParseCSV' \
    'TestMenuWithHashInUrl -> TestMenuWithHashInURL' \
    'TestMenuWithUnicodeUrls -> TestMenuWithUnicodeURLs' \
    'doTestMenuWithUnicodeUrls -> doTestMenuWithUnicodeURLs' \
; do
    echo "$rule"
    gofmt -r "$rule" -w */*.go *.go
done

# Can't change blackfriday.HtmlRendererParameters yet, I think...

gofmt -r 'BaseUrl -> BaseURL' -w commands/*.go

exit

# Problematic ones: BaseUrl and Url (e.g. .Site.BaseUrl and .Page.Url)

for rule in \
    'BaseUrl -> BaseURL' \
    'Url -> URL' \
; do
    gofmt -r "$rule" -w */*.go *.go
done

[bep]

Merged in 67df33f Good job, cool script.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.