Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add services config page #1781

Closed
wants to merge 1 commit into from
Closed

Add services config page #1781

wants to merge 1 commit into from

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Jul 14, 2022 •
edited
Loading

@coliff coliff requested a review from bep July 21, 2022 02:56
@coliff coliff requested a review from jmooring October 18, 2022 13:45
@coliff coliff force-pushed the chalin-mbp-services-config-2022-07-14 branch from 5e32223 to 8784f94 Compare October 18, 2022 13:45
@jmooring
Copy link
Member

jmooring commented Nov 7, 2022

data/docs.json is generated from source with mage GenDocsHelper. We would need to update Hugo's source to generate the services key, and this isn't a simple change (at least not for me). As much as I dislike the idea, for now I suggest we hard code the default config settings.

@jmooring jmooring removed their request for review November 7, 2022 03:13
@jmooring
Copy link
Member

This is on hold until we make a decision on #1888.

@jmooring
Copy link
Member

jmooring commented Nov 7, 2023

This will be addressed with #1888

@jmooring jmooring closed this Nov 7, 2023
@jmooring jmooring mentioned this pull request Nov 7, 2023
Open
@chalin chalin deleted the chalin-mbp-services-config-2022-07-14 branch November 7, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bep bep Awaiting requested review from bep

Assignees
No one assigned
Labels
NeedsToWait
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document services config
2 participants
@chalin @jmooring