Align permalinks examples #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns examples in
/content-management/urls/#site-configurationin such a way that they all contain thepermalinksconfig key like the one for the example forpostsunder#tokensdoes.For context: I opted to add the config key for the other three because that one made it clear to me, that the
permalinkskey is the one to put these under (in order to use this feature).Aligning the examples in such a way might make them eligible to remove the
copy=falseflag, what do you think?I'm also open to change this PR so that the example for
postsdoes not have thepermalinkskey in it.