ci(Netlify): specify HUGO_VERSION environment variable once
#2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an environment variable (`HUGO_VERSION` in this case) is going to be same for all contexts (production, deploy-preview & branch-deploy), then there is no need to specify it for each context. Specifying it once under [build.environment] should be enough. From https://docs.netlify.com/configure-builds/file-based-configuration/#deploy-contexts : "any property of a context-aware key, such as [build] or [[plugins]], will be applied to all contexts unless the same property key is present in a more specific context."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes redundant environment variable specification across contexts.
Explanation
The environment variable
HUGO_VERSIONholds the same value for all contexts (production, deploy-preview, and branch-deploy). Specifying it separately for each context becomes redundant.Specifying it once under
[build.environment]should be enough.Reference
From https://docs.netlify.com/configure-builds/file-based-configuration/#deploy-contexts :
Verification
Consider this PR.
HUGO_VERSIONis not specified for the deploy-preview context innetlify.toml. It can be seen from the corresponding Netlify log that Hugo 0.117.0 was used.Output in L37
Output in L76