Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document changes to template functions in v0.128.0 #2637

Closed

Conversation

jmooring
Copy link
Member

@jmooring jmooring commented Jun 23, 2024

  • New: css.TailwindCSS
  • Deprecate/rename: resources.Babel => js.Babel
  • Deprecate/rename: resources.PostCSS => css.PostCSS
  • Deprecate/rename: resources.ToCSS => css.Sass

@jmooring
Copy link
Member Author

This is obviously just a stub at this point:
https://deploy-preview-2637--gohugoio.netlify.app/functions/css/tailwindcss/

The deprecation/renaming stuff is complete.

@jmooring jmooring marked this pull request as draft June 23, 2024 17:21
@bep
Copy link
Member

bep commented Jun 23, 2024

Deprecate/rename: resources.ToCSS => css.SASS

Hmm... Maybe Sass would be more correct?

@jmooring
Copy link
Member Author

Maybe Sass would be more correct?

Yes, it would be.

@bep
Copy link
Member

bep commented Jun 23, 2024

OK, I have

  1. Renamed SASS => Sass
  2. Moved the aliases.

@jmooring jmooring force-pushed the changes-to-funcs-in-v0.128.0 branch 3 times, most recently from 26e83cd to f09c64b Compare June 23, 2024 18:22
@jmooring
Copy link
Member Author

I'm assuming the options map will look something like this:
https://deploy-preview-2637--gohugoio.netlify.app/functions/css/tailwindcss/#options

@jmooring jmooring force-pushed the changes-to-funcs-in-v0.128.0 branch 3 times, most recently from d4a729b to fc9bb74 Compare June 24, 2024 18:27
@bep
Copy link
Member

bep commented Jun 24, 2024

Tailwind options:

type TailwindCSSOptions struct {
	Minify        bool // Optimize and minify the output
	Optimize      bool //  Optimize the output without minifying
	
	// Enable inlining of @import statements.
	// Does so recursively, but currently once only per file;
	// that is, it's not possible to import the same file in
	// different scopes (root, media query...)
	// Note that this import routine does not care about the CSS spec,
	// so you can have @import anywhere in the file.
	InlineImports bool

	// When InlineImports is enabled, we fail the build if an import cannot be resolved.
	// You can enable this to allow the build to continue and leave the import statement in place.
	// Note that the inline importer does not process url location or imports with media queries,
	// so those will be left as-is even without enabling this option.
	SkipInlineImportsNotFound bool
}

@jmooring jmooring force-pushed the changes-to-funcs-in-v0.128.0 branch from fc9bb74 to 106f48d Compare June 24, 2024 20:20
- New: css.TailwindCSS
- Deprecate/rename: resources.Babel => js.Babel
- Deprecate/rename: resources.PostCSS => css.PostCSS
- Deprecate/rename: resources.ToCSS => css.Sass
- Document disableWatch mount parameter
@jmooring jmooring force-pushed the changes-to-funcs-in-v0.128.0 branch from 106f48d to 6caa008 Compare June 24, 2024 20:49
@bep bep marked this pull request as ready for review June 25, 2024 17:10
@bep
Copy link
Member

bep commented Jun 25, 2024

Merged in 012162e

@bep bep closed this Jun 25, 2024
@jmooring jmooring deleted the changes-to-funcs-in-v0.128.0 branch June 25, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants