Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add heyo theme #331

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Add heyo theme #331

merged 1 commit into from
Aug 29, 2023

Conversation

LucasVadilho
Copy link
Contributor

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for hugothemes ready!

Name Link
🔨 Latest commit 9e56964
🔍 Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/64e44afd3181710008fcfad5
😎 Deploy Preview https://deploy-preview-331--hugothemes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LucasVadilho
Copy link
Contributor Author

Apparently it fails because:

7:37:27 PM: error: hermit-v2: no image found for images/tn

@hugo-sid
Copy link
Member

hugo-sid commented Aug 22, 2023

Form https://github.com/gohugoio/hugoThemesSiteBuilder#criteria-for-acceptance-of-a-theme

A theme based on an existing Hugo theme (aka a fork) must be notably different for it to be considered a separate theme altogether. In such cases, you should list few arguments in README.md file mentioning why your theme should be included.

Can you list few arguments in README.md file?

@hugo-sid
Copy link
Member

hugo-sid commented Aug 22, 2023

Apparently it fails because:

7:37:27 PM: error: hermit-v2: no image found for images/tn

This issue has been solved.

@LucasVadilho
Copy link
Contributor Author

LucasVadilho commented Aug 22, 2023

Can you list few arguments in README.md file?

Sure! Just added this to the Credits & thanks section:

  • heyo has a very different style and design, most changes could't be added to Anatole without completely changing the original feel and appearance
  • heyo has a few new shortcodes and settings
  • Alex Bilz Anatole is licenced under MIT, I also cleared with them if they think it's different enough

However, I also understand that it's very subjective. And as I raised to Alex, structuraly speaking, it's very similar to Anatole. So if y'all feel that heyo is not different enough, that's ok too!

Anatole demo | heyo demo

@LucasVadilho
Copy link
Contributor Author

Hey @hugo-sid just pinging you to check if I need to do something else :)

@hugo-sid
Copy link
Member

Thanks for adding Heyo theme.

@hugo-sid hugo-sid merged commit 095c784 into gohugoio:main Aug 29, 2023
5 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants