Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(GitHub action): bump actions/checkout to v4 & actions/setup-go to v5 #426

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

hugo-sid
Copy link
Member

@hugo-sid hugo-sid commented Mar 7, 2024

What does this PR do?

  • There is a waning seen in several GitHub action logs:

    Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

    This PR upgrades actions/checkout to v4 & actions/setup-go to v5 to eliminate this warning.

  • The GitHub action run has failed due to various reasons in the past. This PR moves the 'committing' changes to a separate step. As of this PR, changes are committed only if workflow is run from main branch. This allows experimenting/debugging GitHub actions (specifically the Update submodules step) without concerns about committing changes.

  • Removes 1 theme which is causing the GitHub action to fail. Fixes theme not updated #402 .

Copy link

netlify bot commented Mar 7, 2024

Deploy Preview for hugothemes ready!

Name Link
🔨 Latest commit b4b8a68
🔍 Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/65fd52e74fd0820009eb0772
😎 Deploy Preview https://deploy-preview-426--hugothemes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hugo-sid
Copy link
Member Author

hugo-sid commented Mar 22, 2024

A GitHub action workflow run with workflow file from this branch (ci/upgrade-actions) has succeeded.
Corresponding log can be seen here.

Going ahead with merging this PR.

@hugo-sid hugo-sid merged commit 2d519d6 into main Mar 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

theme not updated
1 participant