Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable demo link and links in theme READMEs #463

Merged
merged 1 commit into from
May 16, 2024
Merged

Disable demo link and links in theme READMEs #463

merged 1 commit into from
May 16, 2024

Conversation

bep
Copy link
Member

@bep bep commented May 15, 2024

This relates to #423.

  • People making money from Hugo themes is a great thing.
  • I suspect a big motivation for Hugo theme authors that run a commercial theme site (or they sell their themes on a commercial site) is to get links to that site from gohugo.io, which has a pretty good Google ranking. This site isn't a free ad platform.
  • This PR may be a bit drastic, but it should simplify some of the related discussions.

Copy link

netlify bot commented May 15, 2024

Deploy Preview for hugothemes ready!

Name Link
🔨 Latest commit 2bfc787
🔍 Latest deploy log https://app.netlify.com/sites/hugothemes/deploys/6644cf8f62fac800085d6ea6
😎 Deploy Preview https://deploy-preview-463--hugothemes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bep bep requested a review from hugo-sid May 15, 2024 15:19
@bep bep marked this pull request as ready for review May 15, 2024 15:23
@bep bep changed the title Disable external links Disable demo link and links in theme READMEs May 15, 2024
@bep
Copy link
Member Author

bep commented May 16, 2024

I'm taking the lack of respose to this as a yay.

@bep bep merged commit 3de0738 into main May 16, 2024
4 checks passed
@hugo-sid
Copy link
Member

hugo-sid commented May 22, 2024

Thanks, @bep, for the idea (& implementation of course) of disabling the links.

One downside of this: it may cause some inconvenience for visitors who can't click on useful links.

This approach required minimal effort on our part. Another approach, though more effort-intensive, would be to periodically check the README for promotional content & de-list them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants