Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filter for create dataset api #215

Merged
merged 5 commits into from
Jun 14, 2019

Conversation

pradithya
Copy link
Collaborator

This follows implementation suggested in #214

fix #214

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradithya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pradithya
Copy link
Collaborator Author

/assign @davidheryanto
/assign @budi
/assign @romanwozniak

@feast-ci-bot
Copy link
Collaborator

@pradithya: GitHub didn't allow me to assign the following users: romanwozniak.

Note that only gojek members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @davidheryanto
/assign @budi
/assign @romanwozniak

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pradithya
Copy link
Collaborator Author

/retest

2 similar comments
@budi
Copy link
Contributor

budi commented Jun 14, 2019

/retest

@pradithya
Copy link
Collaborator Author

/retest

@budi
Copy link
Contributor

budi commented Jun 14, 2019

/lgtm

@feast-ci-bot feast-ci-bot merged commit f9ab779 into feast-dev:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filtering capability to create dataset api
4 participants