feat: Composite generics support #70
Conversation
| testCase := testCase | ||
|
|
||
| t.Run(testCase.name, func(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
I'd rather do it sequentially or at least limit the concurrency to GOMAXPROCs based value.
There was a problem hiding this comment.
According to the Go documentation (go help testflag and go help build), t.Parallel() execution is automatically limited by GOMAXPROCS (as the default value). So, in our case (single package), the binary will already be limited by GOMAXPROCS
-parallel n
Allow parallel execution of test functions that call t.Parallel, and
fuzz targets that call t.Parallel when running the seed corpus.
The value of this flag is the maximum number of tests to run
simultaneously.
While fuzzing, the value of this flag is the maximum number of
subprocesses that may call the fuzz function simultaneously, regardless of
whether T.Parallel is called.
By default, -parallel is set to the value of GOMAXPROCS.
Setting -parallel to values higher than GOMAXPROCS may cause degraded
performance due to CPU contention, especially when fuzzing.
Note that -parallel only applies within a single test binary.
The 'go test' command may run tests for different packages
in parallel as well, according to the setting of the -p flag
(see 'go help build').
I can definitely change this to sequential if you're still having doubts about the CPU load during the execution, this will only change the execution time, not the result
There was a problem hiding this comment.
Ok, let's leave it as is if it's already bound by GOMAXPROCS, yep my concern was CPU load especially if the number of tests grows.
|
Thanks, @defaulterrr It's in v3.1.2 already |
Hey there! I noticed that my last PR #67 did not quite cover all possible cases with generic declarations so i followed up with some fixes. I've also implemented Go-based snapshot testing, hope you don't mind!
The general idea right now is to use go/printer package to render constraints references instead of manual traversal and string concatenation
Changelog: