unix sockets on windows #1637
unix sockets on windows #1637
Conversation
|
I can delete the check for unix sockets support if we don't want to support EOL windows platforms, like windows 7, 8 and a few of the first versions of windows 10. |
There was a problem hiding this comment.
Thanks for the patch, it looks fine overall to me.
Currently we have a change freeze since we are about to release a new version r32, see #1427 (comment). So there's a possibility this might not be merged until after that, but I don't mind either way.
os_windows.go
Outdated
| gDefaultSocketPath = filepath.Join(data, "lf", fmt.Sprintf("lf.%s.sock", gUser.Username)) | ||
| syscall.Close(socket) | ||
| } | ||
|
|
There was a problem hiding this comment.
Slightly pedantic, but I suggest to move this to the bottom of the init function after the path definitions, to maintain the same order as os.go.
There was a problem hiding this comment.
Thanks for the changes once again.
Regarding support for IP sockets, I'm not sure about this since I'm not a Windows user. There's also the question of whether the socket should be created in os.TempDir instead of data, which is more for files representing the state of lf.
I think it might be better if leave this PR open for a bit longer to see if anyone else wants to comment.
|
I'm actively using this change on my Windows machine and I haven't encountered any problems yet. About the creation directory of the socket: yes, maybe I agree with you, let's wait for other people to see their opinions. |
Windows supports unix domain sockets for some years now but they are not used in lf. Changed the default socket to
unixon windows to bring the benefits of it on the windows platform also. If the unix sockets are not supported ( very old version of windows ) fallback on tcp localhost sockets.https://devblogs.microsoft.com/commandline/af_unix-comes-to-windows/