Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc sort improvements #1706

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Misc sort improvements #1706

wants to merge 6 commits into from

Commits on Aug 31, 2024

  1. sort: use text/collate for faster and allocation-less test comparison

    @q3cpma
    q3cpma committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    57268df View commit details
    Browse the repository at this point in the history

  2. sort: don't check dir.reverse during each comparison

    @q3cpma
    q3cpma committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    9648116 View commit details
    Browse the repository at this point in the history

  3. sort: no point in sorting with dirfirst if dironly

    @q3cpma
    q3cpma committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    3ae0aa9 View commit details
    Browse the repository at this point in the history

  4. sort: don't double sort when dirfirst is set 

    In fact, sort after all the filtering is done, makes more sense
    @q3cpma
    q3cpma committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    1953943 View commit details
    Browse the repository at this point in the history

  5. sort: filter first and only once before sorting 

    Mostly authored by @joelim-work
    @q3cpma
    q3cpma committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    79cb614 View commit details
    Browse the repository at this point in the history

  6. Revert misguided text/collate usage 

    And add the following optimizations:
* Hoist the branching out of normalize()
* In extSort, normalize the names only when extensions are equal
* In extSort, use strings.Compare that does a proper 3-way comparison in Go 1.23
    @q3cpma
    q3cpma committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    c8f195e View commit details
    Browse the repository at this point in the history