Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image previews containing long lines #1737

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Fix image previews containing long lines #1737

merged 1 commit into from
Jun 4, 2024

Conversation

joelim-work
Copy link
Collaborator

@joelim-work joelim-work commented Jun 2, 2024

To reproduce, use chafa --polite on -f symbols -s "${2}x{3}" "$1" for an image preview.

@pzant
Copy link

pzant commented Jun 2, 2024

To reproduce, use chafa --polite on -s symbols -s "${2}x{3}" "$1" for an image preview.

Incorrect. It sholud be like this: chafa --polite on -f symbols -s "${2}x{3}" "$1" in preview code.

@joelim-work
Copy link
Collaborator Author

Incorrect. It sholud be like this: chafa --polite on -f symbols -s "${2}x{3}" "$1" in preview code.

Sorry, that was a typo. I have updated the PR description.

To reproduce, use `chafa --polite on -f symbols` for an image preview.
@joelim-work joelim-work merged commit 9b9082a into gokcehan:master Jun 4, 2024
4 checks passed
@joelim-work joelim-work deleted the fix-long-chafa-preview branch June 4, 2024 00:13
@joelim-work joelim-work added the fix Pull requests that fix existing behavior label Jun 24, 2024
@joelim-work joelim-work added this to the r33 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull requests that fix existing behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chafa symbol preview error
2 participants