Switching back and forth between : and !/$/%/& command-line modes
#960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# What this does This makes the following changes: 1. If the we are in any of the shell command-line modes (after pressing one of `!/$/%/&`) and the cursor is at the first character, pressing `backspace` switches you to the `:` mode. Pressing `backspace` again will take you out of the command-line mode as before (this commit extends the recent [escape on backspace] functionality). [escape on backspace]: gokcehan@36a7a18 2. Conversely, if we are in the `:` mode and the cursor is at the first character, pressing one of `!/$/%/&` will take you to the corresponding mode insted of inserting that character. This is a very minor change, since already pressing `:!ls<ret>` and `!ls <ret>` in `lf` has the same effect. After this commit, these will also look the same even before pressing `<ret>`. 3. There is a minor bugfix to the [escape on backspace] commit. In `>` mode (when a program launched with `&` waits for input), `lf` currently switches to normal mode on `backspace` without terminating the program. After this commit, the "escape on backspace" functionality is disabled in `>` mode. This idea is borrowed from the [Julia REPL modes]. [Julia REPL modes]: https://docs.julialang.org/en/v1/stdlib/REPL/#Help-mode # What problems this solves The main problem I want to solve is that I often type `$ls <many options>` and realize I wanted `!ls` all along. Currently, there is no easy way to switch. With this commit, it becomes trivial. This problem also occurs when you scroll up to a `$ls <many options>` command in history. Finally, since `!` and `:!` have essentially the same effect in `lf`, I think they should look the same.
|
@ilyagr It looks good. Thanks for the patch. |
ilyagr
added a commit
to ilyagr/lf
that referenced
this pull request
Oct 16, 2022
Documents gokcehan#960, also known as gokcehan@52a151a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This makes the following changes:
!/$/%/&) and the cursor is at the first character, pressingbackspaceswitches you to the:mode. Pressingbackspaceagain will take you out of the command-line mode as before (this commit extends the recent escape on backspace functionality).Conversely, if we are in the
:mode and the cursor is at the first character, pressing one of!/$/%/&will take you to the corresponding mode insted of inserting that character. This is a very minor change, since already pressing:!ls<ret>and!ls <ret>inlfhas the same effect. After this commit, these will also look the same even before pressing<ret>.There is a minor bugfix to the escape on backspace commit. In
>mode (when a program launched with&waits for input),lfcurrently switches to normal mode onbackspacewithout terminating the program. After this commit, the "escape on backspace" functionality is disabled in>mode.This idea is borrowed from the Julia REPL modes.
What problems this solves
The main problem I want to solve is that I often type
$ls <many options>and realize I wanted!lsall along. Currently, there is no easy way to switch. With this commit, it becomes trivial.This problem also occurs when you scroll up to a
$ls <many options>command in history.Finally, since
!and:!have essentially the same effect inlf, I think they should look the same.